feat(wallet_ffi): new ffi method to create output features #4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
May 19, 2022
stringhandler
pushed a commit
that referenced
this pull request
May 20, 2022
…g size for dibbler) (#4118) Description --- * Created a new FFI method to create an output features object, by passing the byte values as parameters. * I decided to not expose the DAN layer features, as they are most likely going to change and also would require exposing more struct definitions. * Updated the C header with the definition of the new method Motivation and Context --- Currently the mobile apps cannot properly import faucet UTXOs, as they are passing null values for output features and covenants to the `wallet_import_external_utxo_as_non_rewindable` method, which is not allowed. So the mobile apps needs new FFI methods to create both output features and covenants. This pull request deals with output features only. **This PR is an adaptation due to the output flags size, as the [original PR](#4109) was done over development which has consensus breaking changes (flag size was increased from 1 byte to 2 bytes).** How Has This Been Tested? --- Created two new unit tests for the new FFI method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently the mobile apps cannot properly import faucet UTXOs, as they are passing null values for output features and covenants to the
wallet_import_external_utxo_as_non_rewindablemethod, which is not allowed. So the mobile apps needs new FFI methods to create both output features and covenants. This pull request deals with output features only.How Has This Been Tested?
Created two new unit tests for the new FFI method