feat: implement qr code for base node #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a QR code for the link `tari://base_nodes/add&name=NODE_ID&peer=PEER` Where PEER is a formatted string: PublicKey::PublicAddress Motivation and Context Users should be able easy to add a base node just scanning the QR printed in base node console. How Has This Been Tested? Manually, running the `tari_base_node` and scanning the QR using the Aurora app. The base node should be listed if everything is correct. Changes to be committed: modified: .gitignore modified: applications/tari_base_node/Cargo.toml modified: applications/tari_base_node/src/commands/command/whoami.rs
alex1307
changed the title
alex1307
changed the title
alex1307
changed the title
Description Create a QR deep link code pointing to `/base_nodes/add` according to the RFC-0154, so that the wallet can scan it and set the base node. Motivation and Context Users should be able easy to add a base node just scanning the QR printed in base node console. How Has This Been Tested? Manually, running the `tari_base_node` and scanning the QR using the camera and opening the URL with the Aurora app. The base node should should be listed.
stringhandler
changed the title
stringhandler
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a QR code for the link
tari://base_nodes/add&name=NODE_ID&peer=PEERWhere PEER is a formatted string: PublicKey::PublicAddress
Motivation and Context
Users should be able easy to add a base node just scanning the QR printed in base node console.
How Has This Been Tested?
Manually, running the
tari_base_nodeand scanning the QR using the Aurora app.The base node should be listed if everything is correct.