fix: use of branch seed in key manager #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
reviewed
Jan 26, 2022
| @@ -77,7 +77,12 @@ where | |||
|
|
|||
| /// Derive a new private key from master key: derived_key=SHA256(master_key||branch_seed||index) | |||
| pub fn derive_key(&self, key_index: u64) -> Result<DerivedKey<K>, ByteArrayError> { | |||
| let concatenated = format!("{}{}", self.seed.entropy().to_vec().to_hex(), key_index); | |||
There was a problem hiding this comment.
@philipr-za does this indicate the current wallets are all deriving on the same branch??
There was a problem hiding this comment.
Ja it would! This is a good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The branch seed was not used (even if it was mentioned in the comment).
Motivation and Context
Problem with doubling the tokens in collectibles because of the pub keys for asset and tokens were the same.
How Has This Been Tested?
Manually (fixed the double problem in collectibles)
Added new cargo test for the use of the branch seed.