From a39efa8cd6bd5b864e56ad76c5dc89231d5e9f30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 17 Apr 2021 16:01:48 +0200 Subject: [PATCH] [ABI-stability] Revert API change for HeapProfiler::TakeHeapSnapshot This reverts a small part of 7f52e4f92d3d3ded9a1701ee2f93966075ae5004. --- include/v8-profiler.h | 3 +-- src/api/api.cc | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/include/v8-profiler.h b/include/v8-profiler.h index b398ae4d088..85d3f8a4821 100644 --- a/include/v8-profiler.h +++ b/include/v8-profiler.h @@ -900,8 +900,7 @@ class V8_EXPORT HeapProfiler { const HeapSnapshot* TakeHeapSnapshot( ActivityControl* control = nullptr, ObjectNameResolver* global_object_name_resolver = nullptr, - bool treat_global_objects_as_roots = true, - bool capture_numeric_value = false); + bool treat_global_objects_as_roots = true); /** * Starts tracking of heap objects population statistics. After calling diff --git a/src/api/api.cc b/src/api/api.cc index d77b46cf4af..b0315e2b15f 100644 --- a/src/api/api.cc +++ b/src/api/api.cc @@ -10043,11 +10043,10 @@ void HeapProfiler::ClearObjectIds() { const HeapSnapshot* HeapProfiler::TakeHeapSnapshot( ActivityControl* control, ObjectNameResolver* resolver, - bool treat_global_objects_as_roots, bool capture_numeric_value) { + bool treat_global_objects_as_roots) { return reinterpret_cast( reinterpret_cast(this)->TakeSnapshot( - control, resolver, treat_global_objects_as_roots, - capture_numeric_value)); + control, resolver, treat_global_objects_as_roots, false)); } void HeapProfiler::StartTrackingHeapObjects(bool track_allocations) {