Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 support? #8

Open
kristianmandrup opened this issue Jul 27, 2024 · 1 comment
Open

Svelte 5 support? #8

kristianmandrup opened this issue Jul 27, 2024 · 1 comment

Comments

@kristianmandrup
Copy link

Hi,

Your library looks promising. Like someone else mentioned, it was not clear if the code for the examples was available but I found the answer via a closed issue and have now downloaded the full library to take a peek.

I will try to use the library in a SvelteKit 2 app using Svelte 5.
On install I get a peer dependencies warning. Have you or anyone else made it work with Svelte 5?
If so, let's perhaps add it to the list of allowed peers?

"^3.19.0 || ^4.0.0 || ^5.0.0"

dependencies:
+ svelte-dnd-list 0.1.8

 WARN  Issues with peer dependencies found
.
└─┬ @sveltejs/vite-plugin-svelte 3.1.1
  └─┬ svelte-hmr 0.16.0
    └── ✕ unmet peer svelte@"^3.19.0 || ^4.0.0": found 5.0.0-next.199
@kristianmandrup
Copy link
Author

Btw, in the Programmatic example, there seemed to be an error:

		// place
		if (to.dropZoneID === 'a') {
			colors1 = [...colors1];
			colors1.splice(to.index, 0, moving);
		} else if (to.dropZoneID === 'b') {
			colors2 = [...colors2];
			colors2.splice(to.index, 0, moving);
		}

The splice function only takes 2 arguments, so the moving argument is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant