-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): put automata dcap v3 ra behind proxy #16867
Conversation
and who is the owner to perform upgrade? The idea was deploy non-upgradable contract to use address manager to switch to a new verifier if needed. |
Owner to upgrade i guess is the proxy owner. |
feat(protocol): put automata dcap v3 ra behind proxy
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
If this contract is stateless, then maybe we just deploy a new version. |
In our current design: both can work. I have no strong opinion, maybe B is more handy and easier (?). Please you decide. |
The reason I think we should keep this contract not upgradeable is to ensure we can sync with the official repo's code easily, otherwise, the official repo is not upgradeable and ours is, then we always have to manually copy code and make necessary changes to our copy to ensure it works. |
Given that this verifier has state data, I'm OK with upgradeability |
As per request. #16864 (comment)