-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blobstorage): fix command instructions and missing local_docker folder in packages/blobstorage #16464
Conversation
that readme is a hangover from when we used MongoDB which we no longer do. they can be removed from the readme. the repo has been changed to use MySQL like the rest of the packages |
@cyberhorsey, thank you for the clarification, I'll update the README.md |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16464 +/- ##
==========================================
+ Coverage 26.82% 28.26% +1.43%
==========================================
Files 105 2 -103
Lines 6188 46 -6142
==========================================
- Hits 1660 13 -1647
+ Misses 4348 32 -4316
+ Partials 180 1 -179
☔ View full report in Codecov by Sentry. |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
I noticed that the current commands in the README.md to start the indexer and server are not correctly formatted and don't work. They are missing the
go
keyword to run Go programs. I have updated these commands to the proper format.Also, the README.md references a
local_docker
directory for starting MongoDB withdocker-compose up -d
, but this directory does not exist in the current repository structure so I can't start the indexer & server. Maybe it wasn't staged and commited?If the
local_docker
directory and the associateddocker-compose.yml
file are available but have not been pushed to the repository, could they please be added?UPDATE:
I've made the necessary updates to reflect the migration to a mysql database setup. Including:
docker-compose.yml
file to facilitate starting the MySQL database.