Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blobstorage): fix command instructions and missing local_docker folder in packages/blobstorage #16464

Merged
merged 13 commits into from
Mar 20, 2024

Conversation

SamiAlHassan
Copy link
Contributor

@SamiAlHassan SamiAlHassan commented Mar 16, 2024

I noticed that the current commands in the README.md to start the indexer and server are not correctly formatted and don't work. They are missing the go keyword to run Go programs. I have updated these commands to the proper format.

Also, the README.md references a local_docker directory for starting MongoDB with docker-compose up -d, but this directory does not exist in the current repository structure so I can't start the indexer & server. Maybe it wasn't staged and commited?

If the local_docker directory and the associated docker-compose.yml file are available but have not been pushed to the repository, could they please be added?

UPDATE:

I've made the necessary updates to reflect the migration to a mysql database setup. Including:

  • Adding a docker-compose.yml file to facilitate starting the MySQL database.
  • Updating all relevant configurations to accurately reflect the migration from MongoDB to mysql.
  • Revising the README to accurately represent these changes and provide correct command instructions.

@cyberhorsey
Copy link
Contributor

cyberhorsey commented Mar 16, 2024

that readme is a hangover from when we used MongoDB which we no longer do. they can be removed from the readme. the repo has been changed to use MySQL like the rest of the packages

@SamiAlHassan
Copy link
Contributor Author

@cyberhorsey, thank you for the clarification, I'll update the README.md

@SamiAlHassan
Copy link
Contributor Author

I've made the updates to the package with the mysql db. This includes adding the docker-compose.yml file to facilitate starting the MySQL db, updating all relevant configurations to reflect the migration, and revising the README.md to represent these changes.

Server Indexer
Previous Setup Image Current Setup Image

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.26%. Comparing base (f53766b) to head (4c0afc9).
Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16464      +/-   ##
==========================================
+ Coverage   26.82%   28.26%   +1.43%     
==========================================
  Files         105        2     -103     
  Lines        6188       46    -6142     
==========================================
- Hits         1660       13    -1647     
+ Misses       4348       32    -4316     
+ Partials      180        1     -179     
Flag Coverage Δ
blobstorage 28.26% <ø> (?)
eventindexer ?
guardian-prover-health-check ?
relayer ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyberhorsey cyberhorsey enabled auto-merge March 20, 2024 23:45
@cyberhorsey cyberhorsey added this pull request to the merge queue Mar 20, 2024
Merged via the queue into taikoxyz:main with commit a7e7f1a Mar 20, 2024
4 of 5 checks passed
Copy link

gitpoap-bot bot commented Mar 20, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants