Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(prover): prove block tx gas limit #357

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Conversation

cyberhorsey
Copy link
Contributor

users are running out of gas due to verifying unknown amount of blocks, similiar to proposer issue.

failure: https://explorer.test.taiko.xyz/tx/0xb2b742165599d96c3c19e3e2263ffcf6f3362f6650f1b64db13175f68a352f4f

success of same blockID after from same sender (uses less gas): https://explorer.test.taiko.xyz/tx/0xcfa06718a25e41f799f310804149cb2483d0c7d0baa1fa52e64932f87c196851

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #357 (23d1bb2) into main (ffe2f90) will decrease coverage by 0.03%.
The diff coverage is 74.07%.

❗ Current head 23d1bb2 differs from pull request most recent head 16c4f7c. Consider uploading reports for the commit 16c4f7c to get more accurate results

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   52.19%   52.16%   -0.03%     
==========================================
  Files          36       36              
  Lines        4508     4520      +12     
==========================================
+ Hits         2353     2358       +5     
- Misses       1892     1897       +5     
- Partials      263      265       +2     
Files Changed Coverage Δ
prover/proof_submitter/util.go 50.00% <ø> (ø)
prover/config.go 92.30% <33.33%> (-4.17%) ⬇️
prover/proof_submitter/valid_proof_submitter.go 68.78% <85.00%> (-0.72%) ⬇️
prover/prover.go 35.95% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha enabled auto-merge (squash) August 9, 2023 06:49
@davidtaikocha davidtaikocha merged commit 8ed4da2 into main Aug 9, 2023
@davidtaikocha davidtaikocha deleted the prover_gas_limit branch August 9, 2023 06:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants