Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(raiko): Cherry-pick A7 updates(#182) #197

Merged
merged 8 commits into from
May 14, 2024
Merged

feat(raiko): Cherry-pick A7 updates(#182) #197

merged 8 commits into from
May 14, 2024

Conversation

smtmfft
Copy link
Contributor

@smtmfft smtmfft commented May 13, 2024 •
edited
Loading

Cherry-pick updates from a7

  1. code refine, print sgx guest output
  2. make all docker use same enclave.key -- we could have better way to manage this secret, although this one is meaningless and just acts like a id.
  3. Add feature to back compatible with a7 for better release process

@smtmfft
feat(raiko): Sgx output print for better debug experience (#182)
f0a602e 
* update blob data format as some nodes return differently

* code refine, print sgx guest output

Signed-off-by: smtmfft <[email protected]>

---------

Signed-off-by: smtmfft <[email protected]>
@smtmfft smtmfft requested review from Brechtpd and johntaiko and removed request for Brechtpd May 13, 2024 15:38
smtmfft and others added 3 commits May 13, 2024 23:39
@smtmfft
feat(raiko): make all enclave have the same signer (#183)
d595c82 
* feat(raiko): put gramine-signer into docker structure to ensure all guest has the same signer

Signed-off-by: smtmfft <[email protected]>

* add .pem

Signed-off-by: smtmfft <[email protected]>

---------

Signed-off-by: smtmfft <[email protected]>
@smtmfft
back compatible with a7
9d83f21 
Signed-off-by: smtmfft <[email protected]>
@smtmfft
fix fmt
0d61f05 
Signed-off-by: smtmfft <[email protected]>
Brechtpd
Brechtpd approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but instead of feature to select the special A7 behavior I would just check the network dynamically instead (like we already support ethereum and A6 next to A7): #198.

@smtmfft
Copy link
Contributor Author

smtmfft commented May 14, 2024

Looks good, but instead of feature to select the special A7 behavior I would just check the network dynamically instead (like we already support ethereum and A6 next to A7): #198.

Fixed

@smtmfft smtmfft changed the title feat(raiko): Sgx output print for better debug experience (#182) feat(raiko): Cherry-pick A7 updates(#182) May 14, 2024
@smtmfft
fix merge conflict
2b132b0 
Signed-off-by: smtmfft <[email protected]>
@smtmfft smtmfft merged commit b3c2c1d into main May 14, 2024
10 of 11 checks passed
@smtmfft smtmfft deleted the pick-a7 branch May 14, 2024 03:24
@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@johntaiko johntaiko Awaiting requested review from johntaiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smtmfft @Brechtpd