Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const_fn(nightly) in favor of custom cfgs #28

Open
taiki-e opened this issue Oct 9, 2020 · 0 comments
Open

Remove const_fn(nightly) in favor of custom cfgs #28

taiki-e opened this issue Oct 9, 2020 · 0 comments
Labels
breaking-change This proposes a breaking change

Comments

@taiki-e
Copy link
Owner

taiki-e commented Oct 9, 2020

As said in #17 (comment), to use the nightly only unstable feature, it needs to enable the feature at crate-level, and in any case, it needs build-script. So, this may not be very useful in practice.

This allows you to allow cfgs to be passed directly to const_fn.

- #[const_fn(cfg(my_cfg))]
+ #[const_fn(my_cfg)]

- #[const_fn(cfg(all(my_cfg1, my_cfg2)))]
+ #[const_fn(all(my_cfg1, my_cfg2))]
@taiki-e taiki-e added the breaking-change This proposes a breaking change label Oct 9, 2020
@taiki-e taiki-e mentioned this issue Jun 15, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This proposes a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant