-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPT_OUT in environment should override .opt-in file #219
Comments
Hæ @gthb Do you have a particular use case for this or is this a theoretical case? What I thought about, from time to time, for quite some time now and which is now refreshed by this issue you raised, would be to make a v2 release that actually evaluates all the opt in and opt out variables available, in a hierarchical manner (that is: env variable overrides dot-file, which itself overrides package.json config object; opting out of an option on a level overrides opting into it on the same level and below). Kveðja til uppáhalds eyjunnar minnar! |
Hæ! Yep, that would align with our requirements, and was the behavior I expected, until I tried it. :) My use case was that I was introducing a lint-the-modified-files pre-commit hook to my team and proposing that people opt in with an |
Ég skila því! |
Having opted in with an
.opt-in
file, I should then still be able to opt out for individual commands with anOPT_OUT=pre-commit
environment variable. Right now theOPT_OUT
environment variable does not override the.opt-in
file.The text was updated successfully, but these errors were encountered: