It takes a long time to make the first request

[kaatt]

With got v11:

> console.time('done');got('https://facebook.com').then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 302.025ms
> console.time('done');got('https://facebook.com', { http2: true }).then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 60188.968ms

> console.time('done');got('https://twitter.com').then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 2343.526ms

> console.time('done');got('https://twitter.com', { http2: true }).then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 5333.237ms

> console.time('done');got('https://google.com').then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 983.180ms
> console.time('done');got('https://google.com', { http2: true }).then(x => console.timeEnd('done'))
Promise { <pending> }
> done: 1520.592ms

Not sure what's causing it. Pages are speedy when I load them in Chrome.

[szmarczak]

Try

got('https://google.com', { http2: true }).then(x => {
    console.time('done');got('https://google.com', { http2: true }).then(x => console.timeEnd('done'))
})

When you make a first HTTP2 request, it may use additional time to set up the HTTP2 session. Further requests should be faster.

[kaatt]

Is there any fix for this? Facebook.com takes 60s for the first request.

got('https://facebook.com', { http2: true }).then(x => {
    console.time('done');got('https://facebook.com', { http2: true }).then(x => console.timeEnd('done'))
})

[szmarczak]

I'm working on it right now

[szmarczak]

Indeed. Fixed a few bugs, and for google.com (150ms compared to 360ms) it is >2x faster than HTTP1. But for facebook.com it waits always 60s for some reason.

[szmarczak]

Sometimes it gives the proper result, sometimes it waits 60s...

[szmarczak]

Nope.

	http2wrapper.request('https://facebook.com', () => {
		console.log('got response');
	}).end();

this works as expected... but it doesn't work with Got for some reason...

[szmarczak]

It has to do something with redirects or HTTP2 origins. If you add followRedirect: false it works as expected.

[szmarczak]

No. If you query https://www.facebook.com and disable redirects it also hangs.

[szmarczak]

Hmmm.

http2wrapper.request('https://www.facebook.com', () => {
	console.log('got response');
}).end();

works as expected so I suspect it's a bug in Got.

Edit:

request('https://www.facebook.com', response => {
	response.resume();
	response.once('end', () => {
		console.log('got end');
	});
}).end();

shows it's a bug in Got. But I'm still not sure.

[szmarczak]

maybe

[szmarczak]

http2: true, decompress: false works as expected but if you set decompress to true it hangs

[szmarczak]

Testing on http2-wrapper@master

[kaatt]

you can maybe try other popular sites and see if the same issue is happening with any of them. might help in filtering out the issue with compression

[szmarczak]

request('https://www.facebook.com', {
	headers: {
		'user-agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36',
		'accept-encoding': 'gzip, deflate, br'
	}
}, response => {
	response.resume();
	response.on('data', chunk => {
		console.log(chunk.toString().length);
	});
	response.once('end', () => {
		console.log('got end');
	});
}).end();

It's a http2-wrapper bug 10000%

[szmarczak]

Either it's a bug in Node.js, nghttp2 (the underlying HTTP2 implementation) or in Facebook itself:

const {connect} = require('http2');
const session = connect('https://www.facebook.com');
session.once('remoteSettings', () => {
	console.log('got settings');
	session.request({
		'user-agent': 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3904.70 Safari/537.36',
		'accept-encoding': 'gzip, deflate, br'
	}).once('response', () => {
		console.log('got headers');
	}).on('data', chunk => {
		console.log(chunk.toString().length);
	}).on('end', () => {
		console.log('got end');
	}).resume();
});

[szmarczak]

It's a bug in Facebook, if you remove , br from accept-encoding you receive the end event.

[szmarczak]

It may be also a bug in Node.js, I need to check that.

[kaatt]

could this be an issue in proxygen? https://engineering.fb.com/production-engineering/introducing-proxygen-facebook-s-c-http-framework/

i see chrome's only sending "br" for "accept-encoding" chrome's sending accept-encoding: gzip, deflate, br for "accept-encoding"

[szmarczak]

that's what I'm sending too

[szmarczak]

It's a Node.js bug, curl --http2 -H 'accept-encoding: gzip, deflate, br' https://www.facebook.com>/dev/null works as expected.

[szmarczak]

Please see the issue above. I'll release a new beta right now.

[szmarczak]

Released 1.0.0-beta.4.4