Fix autowiring of APIv4 action classes

Author: Dominic Tubach

Civi/Civioffice/DependencyInjection/Compiler/Api4ActionPropertyAutowireFixPass.php

@@ -0,0 +1,32 @@
+<?php
+declare(strict_types = 1);
+
+namespace Civi\Civioffice\DependencyInjection\Compiler;
+
+use Civi\Api4\Generic\AbstractAction;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+/**
+ * Symfony DI (v5 and v6) tries to autowire properties annotated with @required.
+ * Though CiviCRM action parameters can be annotated in this way to make them
+ * mandatory. This pass clears the properties that are going to be injected for
+ * APIv4 action classes registered as services in the
+ * Civi\Civioffice\Api4\Action namespace. (In Symfony DI v7 support of
+ * annotations is dropped in favor of PHP attributes.)
+ */
+final class Api4ActionPropertyAutowireFixPass implements CompilerPassInterface {
+
+  public function process(ContainerBuilder $container): void {
+    foreach ($container->getDefinitions() as $id => $definition) {
+      if ([] === $definition->getProperties() || !str_starts_with($id, 'Civi\\Civioffice\\Api4\\Action\\')) {
+        continue;
+      }
+
+      if (is_a($id, AbstractAction::class, TRUE)) {
+        $definition->setProperties([]);
+      }
+    }
+  }
+
+}

services/civioffice.php

@@ -21,6 +21,7 @@
 /** @var \Symfony\Component\DependencyInjection\ContainerBuilder $container */
 
 use Civi\Civioffice\Api4\Action\Civioffice\RenderWebAction;
+use Civi\Civioffice\DependencyInjection\Compiler\Api4ActionPropertyAutowireFixPass;
 use Civi\Civioffice\EventSubscriber\ActivityCiviOfficeTokenSubscriber;
 use Civi\Civioffice\EventSubscriber\CaseCiviOfficeTokenSubscriber;
 use Civi\Civioffice\EventSubscriber\CiviOfficeSearchKitTaskSubscriber;
@@ -31,11 +32,14 @@
 use Civi\Civioffice\EventSubscriber\ParticipantCiviOfficeTokenSubscriber;
 use Civi\Civioffice\Render\Queue\RenderQueueBuilderFactory;
 use Civi\Civioffice\Render\Queue\RenderQueueRunner;
+use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 
 if (!$container->has(\CRM_Queue_Service::class)) {
   $container->autowire(\CRM_Queue_Service::class, \CRM_Queue_Service::class);
 }
 
+$container->addCompilerPass(new Api4ActionPropertyAutowireFixPass(), PassConfig::TYPE_BEFORE_REMOVING);
+
 $container->autowire(RenderQueueBuilderFactory::class)
   ->setPublic(TRUE);
 $container->autowire(RenderQueueRunner::class)