Update CRM/Civioffice/DocumentRendererType/LocalUnoconv.php

Co-authored-by: jensschuppe <[email protected]>

Author: mattwire

CRM/Civioffice/DocumentRendererType/LocalUnoconv.php

@@ -212,10 +212,10 @@ public function validateSettingsForm(CRM_Civioffice_Form_DocumentRenderer_Settin
         $unoconv_binary_path = $form->_submitValues['unoconv_binary_path'];
         $unoconv_lock_file_path = $form->_submitValues['unoconv_lock_file_path'];
 
-        // We can't check eg. /usr/bin/unoconv on a site with open_basedir restrictions in place so this check would always fail
-        //if (!file_exists($unoconv_binary_path)) {
-        //    $form->_errors['unoconv_binary_path'] = E::ts("File does not exist. Please provide a correct filename.");
-        //}
+        // There used to be a file_exists() check here for validating that the unoconv binary exists in the given path.
+        // We can't however check eg. /usr/bin/unoconv on a site with open_basedir restrictions in place as this check
+        // would always fail. There is a check running `unoconv --version` in the isReady() method() which implicitly
+        // covers the validation of the unconv binary being accessible.
 
         if (!empty($lockfile_to_check)) {
             if (!file_exists($unoconv_lock_file_path)) {