Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snapshot name warning showing on false negatives #151

Merged
merged 2 commits into from
Mar 8, 2020
Merged

Conversation

iamogbz
Copy link
Collaborator

@iamogbz iamogbz commented Mar 7, 2020

Description

Fixes snapshot name warning showing up incorrectly on snapshot creation.

DevQA

STR

  • git checkout master
  • rm */**.ambr
  • pytest --snapshot-update
  • See warnings

FIX

  • git checkout fix-warning
  • rm */**.ambr
  • pytest --snapshot-update
  • No warnings

Checklist

  • This PR has sufficient test coverage.
  • I will merge this pull request with a semantic title.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #151   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         839    849   +10     
=====================================
+ Hits          839    849   +10

@iamogbz iamogbz requested a review from noahnu March 7, 2020 22:49
@iamogbz iamogbz marked this pull request as ready for review March 8, 2020 04:27
@iamogbz iamogbz added this to the v1.0.0 milestone Mar 8, 2020
@mcataford mcataford self-requested a review March 8, 2020 18:34
Copy link

@mcataford mcataford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRQA LGTM, tested locally, was able to reproduce and to witness this fix in all its glory. 🚀

@iamogbz iamogbz merged commit d56860b into master Mar 8, 2020
@iamogbz iamogbz deleted the fix-warning branch March 8, 2020 18:44
syrupy-bot pushed a commit that referenced this pull request Mar 8, 2020
## [0.3.5](v0.3.4...v0.3.5) (2020-03-08)

### Bug Fixes

* snapshot name warning showing on false negatives ([#151](#151)) ([d56860b](d56860b))
@syrupy-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants