Window interval parser added #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
force-pushed
the
window_interval_parser
branch
5 times, most recently
from
eb284be to
bcc8754
Compare
mustafasrepo
force-pushed
the
window_interval_parser
branch
from
bcc8754 to
cd7a552
Compare
ozankabak
force-pushed
the
window_interval_parser
branch
from
69aac6f to
10dcfb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support INTERVAL Inside Window Frames
Which issue does this PR close?
We have added
INTERVALsupport inside window frames. Now sqlparser can parse queries such asThis PR closes the following issue.
The Rationale for this change
Datafusion now supports window frame queries with this merge. However, since window frame bound only accepts u64 values we cannot run queries like the above on Datafusion. If this PR merges, after some minor changes we would be able to run
RANGEqueries involvingINTERVALs using Datafusion. In the roadmap of Datafusion there is a plan to support different types forWindowFrameBound.