From 88258c90cb7294e0973a4e26ece55f272bd2e763 Mon Sep 17 00:00:00 2001 From: Ari Date: Fri, 29 Apr 2022 15:43:39 -0400 Subject: [PATCH 1/2] fix: target_id -> identifier in acceptance test --- sym/provider/target_resource_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sym/provider/target_resource_test.go b/sym/provider/target_resource_test.go index e993a8e2..0b126e3e 100644 --- a/sym/provider/target_resource_test.go +++ b/sym/provider/target_resource_test.go @@ -85,7 +85,7 @@ func TestAccSymTarget_custom(t *testing.T) { resource.TestCheckResourceAttr("sym_target.custom", "type", "custom"), resource.TestCheckResourceAttr("sym_target.custom", "name", createData.ResourceName), resource.TestCheckResourceAttr("sym_target.custom", "label", "My Custom Target"), - resource.TestCheckResourceAttr("sym_target.custom", "settings.target_id", "am-target"), + resource.TestCheckResourceAttr("sym_target.custom", "settings.identifier", "am-target"), ), }, { @@ -94,7 +94,7 @@ func TestAccSymTarget_custom(t *testing.T) { resource.TestCheckResourceAttr("sym_target.custom", "type", "custom"), resource.TestCheckResourceAttr("sym_target.custom", "name", updateData.ResourceName), resource.TestCheckResourceAttr("sym_target.custom", "label", "Other Custom Target"), - resource.TestCheckResourceAttr("sym_target.custom", "settings.target_id", "am-still-target"), + resource.TestCheckResourceAttr("sym_target.custom", "settings.identifier", "am-still-target"), ), }, }, @@ -136,7 +136,7 @@ func awsIamTarget(t TestData, label, iamGroup string) string { return sb.String() } -func customTarget(t TestData, label, targetId string) string { +func customTarget(t TestData, label, identifier string) string { var sb strings.Builder sb.WriteString(providerResource{org: t.OrgSlug}.String()) @@ -146,7 +146,7 @@ func customTarget(t TestData, label, targetId string) string { type_: "custom", label: label, settings: map[string]string{ - "target_id": targetId, + "identifier": identifier, }, }.String()) From 78dc8fd8c37bcf9dad22882d8dbd8ab486010b2d Mon Sep 17 00:00:00 2001 From: Ari Date: Fri, 29 Apr 2022 15:53:40 -0400 Subject: [PATCH 2/2] fix: custom strategy test target --- sym/provider/strategy_resource_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sym/provider/strategy_resource_test.go b/sym/provider/strategy_resource_test.go index 87a3fc11..a4d3b423 100644 --- a/sym/provider/strategy_resource_test.go +++ b/sym/provider/strategy_resource_test.go @@ -155,7 +155,7 @@ func customStrategy(t TestData, label, implPath string) string { name: t.ResourcePrefix + "-custom-target", label: "Custom Target", settings: map[string]string{ - "target_id": "hello-i-am-target", + "identifier": "hello-i-am-target", }, }.String())