From 68aebe559d57b6eb2ee2f5eed016eb0843221ad9 Mon Sep 17 00:00:00 2001 From: Adam Hughes Date: Sun, 2 Aug 2020 13:11:32 +0000 Subject: [PATCH 1/4] ci: update Codecov orb --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 070feb5..402c4e9 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,7 +1,7 @@ version: 2.1 orbs: - codecov: codecov/codecov@1.1.0 + codecov: codecov/codecov@1.1.1 jobs: lint_markdown: From 66840804692fb2f8c5bdb4ad90a6ee90ea6413ae Mon Sep 17 00:00:00 2001 From: Adam Hughes Date: Sun, 2 Aug 2020 13:20:35 +0000 Subject: [PATCH 2/4] ci: implement reusable executors --- .circleci/config.yml | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 402c4e9..194ef8a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,10 +3,17 @@ version: 2.1 orbs: codecov: codecov/codecov@1.1.1 -jobs: - lint_markdown: +executors: + node: docker: - image: node:14-slim + golang: + docker: + - image: golang:1.14 + +jobs: + lint_markdown: + executor: node steps: - checkout - run: @@ -17,8 +24,7 @@ jobs: command: markdownlint . check_mod_tidy: - docker: - - image: golang:1.14 + executor: golang steps: - checkout - run: @@ -29,8 +35,7 @@ jobs: command: git diff --exit-code -- go.mod go.sum build_source: - docker: - - image: golang:1.14 + executor: golang steps: - checkout - run: @@ -38,8 +43,7 @@ jobs: command: go build ./... lint_source: - docker: - - image: golang:1.14 + executor: golang steps: - checkout - run: @@ -50,8 +54,7 @@ jobs: command: golangci-lint run unit_test: - docker: - - image: golang:1.14 + executor: golang steps: - checkout - run: From b9ab7d41eb1d90a5a751e6684be8ac70034fa3f1 Mon Sep 17 00:00:00 2001 From: Adam Hughes Date: Sun, 2 Aug 2020 13:25:57 +0000 Subject: [PATCH 3/4] ci: use golangci-lint image for lint_source job --- .circleci/config.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 194ef8a..2609c9f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,6 +10,9 @@ executors: golang: docker: - image: golang:1.14 + golangci-lint: + docker: + - image: golangci/golangci-lint:v1.28.1-alpine jobs: lint_markdown: @@ -43,12 +46,9 @@ jobs: command: go build ./... lint_source: - executor: golang + executor: golangci-lint steps: - checkout - - run: - name: Install golangci-lint - command: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.28.1 - run: name: Check for Lint command: golangci-lint run From 01d9861d09c622edb707dde1e694a5bba4135fba Mon Sep 17 00:00:00 2001 From: Adam Hughes Date: Sun, 2 Aug 2020 13:28:38 +0000 Subject: [PATCH 4/4] ci: update golangci-lint --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 2609c9f..2fd2ab8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,7 +1,7 @@ version: 2.1 orbs: - codecov: codecov/codecov@1.1.1 + codecov: codecov/codecov@1.1 executors: node: @@ -12,7 +12,7 @@ executors: - image: golang:1.14 golangci-lint: docker: - - image: golangci/golangci-lint:v1.28.1-alpine + - image: golangci/golangci-lint:v1.29-alpine jobs: lint_markdown: