Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: actions/upload-artifact deprecated #214

Closed
4 tasks done
hirasso opened this issue Feb 9, 2025 · 1 comment Β· Fixed by #215
Closed
4 tasks done

[Bug]: actions/upload-artifact deprecated #214

hirasso opened this issue Feb 9, 2025 · 1 comment Β· Fixed by #215

Comments

@hirasso
Copy link
Member

hirasso commented Feb 9, 2025

What did you expect? 🧐

I expected the deploy workflow to publish updated docs

What actually happened? πŸ˜΅β€πŸ’«

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

https://github.com/swup/docs/actions/runs/13230037987

Swup and plugin versions πŸ“

n/a

What browsers are you seeing the problem on? 🧭

No response

Relevant log output πŸ€“

URL to minimal reproduction πŸ”—

https://github.com/swup/docs/actions/runs/13230037987

Checked all these? πŸ“š

@hirasso hirasso changed the title [Bug]: actions/upload-artifact disabled [Bug]: actions/upload-artifact deprecated Feb 9, 2025
@hirasso
Copy link
Member Author

hirasso commented Feb 9, 2025

Seems like the action using the deprecated upload-artifact action is https://github.com/actions/upload-pages-artifact. I'm currently not sure if we even need the deploy.yml workflow? Aren't we deploying to netlify anyways, without the need for a custom action? πŸ€”

EDIT
yes, we deploy to netlify. Created a PR deleting the deprecated deploy.yml workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant