Add R to Windows' path in SWC Windows Installer

[ethanwhite]

Problem: R is not added to the Windows' path when it is installed. This means that any workshops that use R from the command line will run into problems (as we did at the first Data Carpentry workshop).

Solution: Add R to the path using our Windows' installer.

Challenges: Just to make @wking's life exciting, R's path varies depending on the version. The standard path is C:\Program Files\R\R-x.x.x\bin\ where x.x.x is the version number of the installed version of R.

[wking]

On Thu, May 15, 2014 at 08:07:19PM -0700, Ethan White wrote:

Solution: Add R to the path using our Windows' installer.

I think I've got this working in my repo's 58b7183
(swc-windows-installer.py: Look for an R bin directory, 2014-06-09)
1, but I no longer have access to a Windows machine for testing.
I've tossed in a few additional cleanup commits as well, now that
we're back to focusing on a single implementation language ;).

@ethanwhite, you should be able to bring my script updates into your
local repository with:

$ git pull git://tremily.us/swc-setup-windows-installer.git namespaced

Although I get a trivial conflict there due to cherry-picking your
187c06e (Add indication that the Windows installer is running,
2014-05-04) into my upstream as 7f6cd12. We shouldn't run into this
problem if we can be more consistent about funneling changes through
my repo (which I'm happy to mirror under the SWC namespace. I'm just
waiting on repository allocation 2).

[gvwilson]

What's the status of this one?

[ethanwhite]

1. I need to test this (hopefully in the next few days)
2. If it's OK with you I think we need to pull the installer out into a separate repository to make it easier to maintain. If that works for you can you go add a new repo for it an give @wking and I admin access to it.

[gvwilson]

1. If it's OK with you I think we need to pull the installer out into
   a separate repository to make it easier to maintain. If that works
   for you can you go add a new repo for it an give @wking
   https://github.com/wking and I admin access to it.

Shall do. Preferred repo name?
G

[wking]

On Thu, Jun 12, 2014 at 08:37:48AM -0700, Greg Wilson wrote:

Preferred repo name?

I call my current public repo swc-setup-windows-installer.

[gvwilson]

On 2014-06-12 1:32 PM, W. Trevor King wrote:

On Thu, Jun 12, 2014 at 08:37:48AM -0700, Greg Wilson wrote:

Preferred repo name?

I call my current public repo swc-setup-windows-installer.
Is there a way to transfer ownership to the @swcarpentry user? That
seems like the simplest way forward (if it actually works).
G

[wking]

On Thu, Jun 12, 2014 at 10:44:26AM -0700, Greg Wilson wrote:

2014-06-12 1:32 PM, W. Trevor King:

I call my current public repo swc-setup-windows-installer.

Is there a way to transfer ownership to the @swcarpentry user? That
seems like the simplest way forward (if it actually works).

I'm hosting my public repo locally (not on GitHub), so there's nothing
to transfer.

[gvwilson]

I have created https://github.com/swcarpentry/windows-installer - shall
we move everything there?

[wking]

On Sun, Jun 15, 2014 at 03:36:21PM -0700, Greg Wilson wrote:

I have created https://github.com/swcarpentry/windows-installer -
shall we move everything there?

I've just pushed my script-only branch to master, and my
setup/windows-installer/ namespaced branch to 'namespaced'. I've
cherrypicked @ethanwhite's Inno commits into a rooted 'inno' branch,
and created a new 'namespaced-inno' branch for distributing. Here's
how I see development working:

• Updates to the installer script land in 'master', and are merged
  from there into 'namespaced' (for my aggregation 1) and 'inno'
  (for @ethanwhite).
• Updates to 'inno' (either from merging 'master', or from updating
  the Inno packaging) are merged into 'namespaced-inno' for
  distribution to the bc ecosystem. Folks can merge them into bc and
  gh-pages, or directly into their particular per-workshop repository.

[ethanwhite]

I would personally really prefer to keep all of the inno stuff in 'master' as well to keep this simple. The distribution mechanism for the installer is now using the inno package, so it seems confusing to keep this material separated from the Python script. Plus that way we only have two branches to manage with one being the main development branch and the other for handling your aggregation.

[wking]

On Mon, Jun 16, 2014 at 08:11:27AM -0700, Ethan White wrote:

I would personally really prefer to keep all of the inno stuff in
'master' as well to keep this simple.

Since this discussion is important for future Windows-installer
maintenance, I've replied with a new issue
(swcarpentry/windows-installer#1).

[wking]

Fixed via swcarpentry/windows-installer#11.