Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.swarm_history still around without any use #1387

Closed
noahyor opened this issue Jul 20, 2023 · 6 comments
Closed

.swarm_history still around without any use #1387

noahyor opened this issue Jul 20, 2023 · 6 comments
Labels
C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@noahyor
Copy link
Member

noahyor commented Jul 20, 2023

When I ran swarm and entered some commands, the .swarm_history file remained unchanged.
@noahyor noahyor added Bug The observed behaviour is incorrect or unexpected. Z-User Experience This issue seeks to make the game more enjoyable to play. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. labels Jul 20, 2023
@byorgey
Copy link
Member

byorgey commented Jul 20, 2023 •
edited
Loading

Currently, I think the .swarm_history file is only updated when exiting a scenario. But it might be worth thinking about updating it more frequently.

@noahyor
Copy link
Member Author

noahyor commented Jul 20, 2023

It remained unedited even on exit for some reason.

@byorgey
Copy link
Member

byorgey commented Jul 20, 2023

Oh! I remember. See #253 : the REPL history is no longer stored in .swarm_history, it is stored somewhere like ~/.local/share/swarm/history (but possibly somewhere different depending on if your $XDG_DATA_HOME environment variable is set).

@noahyor noahyor changed the title .swarm_history not working .swarm_history still around without any use Jul 21, 2023
@noahyor noahyor removed Bug The observed behaviour is incorrect or unexpected. Z-User Experience This issue seeks to make the game more enjoyable to play. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. labels Jul 21, 2023
@noahyor
Copy link
Member Author

noahyor commented Jul 21, 2023

Would it make sense to remove this file, since it has no current use?

@noahyor noahyor added Z-User Experience This issue seeks to make the game more enjoyable to play. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. labels Jul 21, 2023
@byorgey
Copy link
Member

byorgey commented Jul 21, 2023

There is no .swarm_history file checked in to the repo, so if there is one in your swarm directory it's probably just an old file from when Swarm used to store its history that way (git will not delete files that are not tracked by the repo). It should be completely safe for you to delete it.

@noahyor
Copy link
Member Author

noahyor commented Jul 21, 2023

Thanks!

@noahyor noahyor closed this as completed Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@byorgey @noahyor