-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on cleaning up a DLS reader after trying to read a invalid file #48
Comments
Ok, please, just to clarify the
|
Both of them are right. |
We need to check the return value of @jjceresa Do you want to do that? Otherwise I would start with that on the upcoming weekend. |
We need to check the return value of ipatch_container_init_iter() everywhere. I guess we must call
Yes I will do, in the whole library. |
I don't think it's necessary to wrap
So there is no need to add |
Ok. |
Original report: LMMS/lmms#5483
In the function
ipatch_dls_nullify_fixups
:libinstpatch/libinstpatch/IpatchDLSReader.c
Lines 531 to 534 in a1af56b
ipatch_container_init_iter
may fail andinst_iter
will be invalid in that case. However, the function is usinginst_iter
without checking for errors.In the reported case, FluidSynth tried to load a directory as a DLS file. However, it may happen for corrupted files as well.
The text was updated successfully, but these errors were encountered: