[PHP Client] Nested models do not deserialize correctly

[who]

If you have nested models in your swagger spec, the nested object does not deserialize correctly.

Given this Swagger 2.0 spec snippet:

...
  "definitions": {
    "BookAuthor": {
      "properties": {
        "name": {
          "type": "string"
        }
      }
    },
    "Book": {
      "properties": {
        "name": {
          "type": "string"
        },
        "bookAuthor": {
          "$ref": "#/definitions/BookAuthor"
        }
      }
    }
  }
...

The PHP client will yield this JSON when returning Book responses.

{"name":"My Book Name","book_author":null}

The fix for this appears to be in the deserialize() method of APIClient.Mustache

Here's the apparent fix:

Change this:

...
      foreach ($instance::$swaggerTypes as $property => $type) {
        if (isset($data->$property)) {
          $original_property_name = $instance::$attributeMap[$property];
          $instance->$property = self::deserialize($data->$original_property_name, $type);
        }
      }
...

To this:

...
      foreach ($instance::$swaggerTypes as $property => $type) {
        $original_property_name = $instance::$attributeMap[$property];
        if (isset($original_property_name)) {
          $instance->$property = self::deserialize($data->$original_property_name, $type);
        }
      }
...

[fehguy]

Thanks. Yes, @who, there is currently no support for nested schemas right now. It will be added, but for now please consider using $ref syntax to flatten them out.

[who]

@fehguy

Using the code that I provided, I am able to deserialize nested models (at least 2 levels deep) correctly.

Would you be willing to take this as a PR ?

[fehguy]

@who i stand corrected, the snipped you put is valid. I read it as there was a schema in a property which is not currently supported in the codegen project.

So yes, please do send a PR. Apologies for the misidentification of the issue.

[who]

@fehguy

I've added it to my existing PHP PR where I've fixed another issue as well.

See PR #630

[fehguy]

great, thank you.

[who]

Closing this, as it's fixed now.