Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook configuration #4

Merged
merged 14 commits into from
Mar 26, 2020
Merged

Update storybook configuration #4

merged 14 commits into from
Mar 26, 2020

Conversation

joanrm20
Copy link
Collaborator

What I did:

  1. Updated the storybook configuration given the latest updates mentioned in Storybook 5.3
  2. Updated stories to CSF.
  3. Remove custom example components in favor of @storybook/react/demo components.
  4. Update README to use npm (hope it's ok).
  5. Update dependencies to latest possible.
  6. Removed the build step, since now the components being used are the ones in point 3 as example, then, it's more up to our dev folks using the starter to create this step with CSS in JS, SCSS, CSS, etc.

@swyxio
Copy link
Owner

swyxio commented Mar 26, 2020

damn, basically rewrote the whole thing! just invited you to collab and will review now.

@swyxio
Copy link
Owner

swyxio commented Mar 26, 2020

LGTM! thank you so much for sharing!

@swyxio swyxio merged commit 85882ac into swyxio:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants