-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indention glitches for long sections #8
Comments
hi, thanks you bro. the plugin is basically a set of patches and the margins are set on the viewport so the glitch you see its just the margins applying when viewport is changing :D I added it to roadmap. It's really annoying |
This happens with all my docs. I know you're just one person... I wish the Obsidian team would implement this as a core feature. |
I am having the same issue, has this been addressed yet? if not can it be bumped up the list a bit :) |
Instead of using the plugin, I modified the css |
Interesting. How would I go about that? What do I need to put in? |
Download my css: https://github.com/jerviscui/Example.Obsidian/blob/main/%E6%96%87%E4%BB%B6%E5%A4%B9/.obsidian/snippets/editor-reading-mode-color.css Then in the Obsidian css snippet enable it. |
I was using the debug tools and noticed that the classes for headers and the following div tags are dynamicaly changed. So just before the larger text is changed I can see the margins set, but when you move past the threashold where everthing left aligns again, the classes are dynamicaly changed with no margins. Just thought this would help in troubleshooting. |
indentation in preview mode is a little bit optimized. If you want test it, u can download the latest release with BRAT, specifing version the 2.0.0 version Also now there is support for editing mode, i for example do not use reading mode anymore |
I just downloaded the manifest and main and replaced them in my plugins directory overtop the ones there It still has the same behavior in reading mode where if it’s a long entry under a heading half way down its starts to left align not honoring the indent anymore on that heading. also is there a way to adjust the text under a heading to line up with the heading instead of indenting that as well |
this bug still present in reading mode, but not in editing XD. the only thing was donde in reading is speed up a little bit the indent itself
in reading mode this kind of indent you can do with just a css. Maybe ill make a option in settings that will do this instead. Just didn't know somebody prefer this way of indent |
Ok cool I didn’t know if editing and reading mode behave the same as far as rendering div tags like I and @jerviscui mentioned. I have tried a lot of different css and couldn’t get that to work at all this plugin has made it a lot easier Also thanks for considering adding the extra indent. That will be exciting. |
also they behave completely different. editing mode is embedded codemirror editor with batteries, while reading mode is purely obsidian feature where all stuff is rendered into "sections". In reading mode its easy to apply any styles. The problem is that the content under this "sections" lacks of anything that points out about which heading is come after. So the way this plugin identify the heading of the content is adding classes to the content sections so you can also set your own css. This classes are added on-the-fly based on current viewport, so if the content under a heading is huge, it losses the last heading from the viewport and the plugin eats shit as this issue point out. The reason why is done this way is that in editing mode the content lacks of this information as well, so we cannot "transfer" this information in rendering of reading view, as other plugin does. But with editing mode support i think it is possible so when it will be done i'll give it a try and maybe no more on-the-fly shit will be needed also, meanwhile you can solve current issue using live-preview if you dont care about the other bugs on editing mode that are not solved yet |
Thanks for the info, I use two modes, edit and read. I only use the edit mode to make modifications to the content. everthing esle I use my notes for is in reading mode. Hopefully you can find a solution to this, if you need me to test anything let me know |
did u tried this css snippet? is working on both modes well, i just found out |
I tried and the css didn’t work for me. I even turned off and back on your plugin but it still didn’t go. |
try disable another snippets and plugins |
Maybe it's been caused after spellcheck occurrences. I open another issue detailing it: #21 |
Hi, first of all - thank you for this amazing plugin! It literally changed the way I use the Obsidian and amazing work!
I have noticed a bug when scrolling through the longer section of a heading. When given heading is very long (expands below the screen space), it starts glitching when the user is scrolling further (indention is changing). I'm uploading a video showing the problem here. Your help with resolving of this issue would be greatly appreciated.
PS. any news regarding the implementation of this feature into the Live Preview mode? Can't wait to see this happening!
Thanks :)
The text was updated successfully, but these errors were encountered: