Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version is always printed incorrectly #136

Closed
bencekiss opened this issue Nov 10, 2022 · 6 comments · Fixed by #137
Closed

Incorrect version is always printed incorrectly #136

bencekiss opened this issue Nov 10, 2022 · 6 comments · Fixed by #137

Comments

@bencekiss
Copy link

bencekiss commented Nov 10, 2022

Bug report

Describe the bug

Running ngx-translate-lint -v with any accepted flags outputs the version of the containing package.json, not the version of the package itself.

To Reproduce

Steps to reproduce the behavior:

  • Create new angular project: ng new test-ngx-translate-lint (or use an existing one)

  • Run npm install ngx-translate-lint -g

  • Navigate to the project's directory

  • Run ngx-translate-lint -v and it outputs Current version: 0.0.0 in the new project

  • Update this new project's package.json version to 1.1.1

  • ngx-translate-lint -v will output Current version: 1.1.1

  • Nitpick: this version number gets logged to the console on every cli run.

Expected behavior

Regardless of where ngx-translate-lint -v is run, it should always output the ngx-translate-lint version. If the latest version is installed, currently it should output Current version: 1.20.0. It also shouldn't always log the version number to the console.

Screenshots

Screen Shot 2022-11-10 at 14 02 35

@romanrostislavovich
Copy link
Owner

Hi @bencekiss thanks a lot for the issue! I will fix it as soon as possible. :)

@romanrostislavovich
Copy link
Owner

🎉 This issue has been resolved in version 1.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@romanrostislavovich
Copy link
Owner

🎉 This issue has been resolved in version 1.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@romanrostislavovich
Copy link
Owner

Hi @bencekiss , pls check.

Fixed on release 1.20.2.

@bencekiss
Copy link
Author

Hey @svoboda-rabstvo thanks for the fix!

@romanrostislavovich
Copy link
Owner

@bencekiss you are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants