From 818157d9932c7c3c99a1f1b6320c2855a6b298b0 Mon Sep 17 00:00:00 2001 From: sverweij Date: Sat, 17 Aug 2024 13:23:50 +0200 Subject: [PATCH] chore(ci): some more windows baby-sitting --- .github/workflows/ci.yml | 2 +- .mocharc.cjs | 2 +- test/main/main.format.spec.mjs | 6 +++++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 215fca3f2..1912ad4b2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -111,7 +111,7 @@ jobs: npm install npm run build - run: npm run depcruise - - run: npx mocha + - run: npx mocha --invert --fgrep "#do-not-run-on-windows" check-berry-integration: runs-on: ubuntu-latest diff --git a/.mocharc.cjs b/.mocharc.cjs index 6c06dfec7..86d637a95 100644 --- a/.mocharc.cjs +++ b/.mocharc.cjs @@ -3,6 +3,6 @@ module.exports = { extension: ["js", "mjs", "cjs"], reporter: "dot", - timeout: 8000, // 8s for testing on windows - with the previous setting of 4s it regularly timed out on the "uses the 'dot' reporter section for the 'x-dot-webpage' output type" test in main.format + timeout: 4000, spec: "test/**/*.spec.{js,mjs,cjs}", }; diff --git a/test/main/main.format.spec.mjs b/test/main/main.format.spec.mjs index 8f4c1491c..e0e78fb11 100644 --- a/test/main/main.format.spec.mjs +++ b/test/main/main.format.spec.mjs @@ -140,7 +140,11 @@ describe("[E] main.format - format", () => { equal(lJSONResult.modules.length, 33); }); - it("uses the 'dot' reporter section for the 'x-dot-webpage' output type", async () => { + // on windos, this tests often times out. As I don't see additional value in + // having the test suite fail on windows, let alone for an experimental feature + // I'm disabling the test on windows (with 'do not run on windows' in the test + // name and a `mocha --invert --fgrep "#do-not-run-on-windows"` on the windows ci) + it("uses the 'dot' reporter section for the 'x-dot-webpage' output type (#do-not-run-on-windows)", async () => { const lResult = await format(cruiseResult, { outputType: "x-dot-webpage", });