From eb7dd3c656be69806dc1ec7d209eb09bedce35c5 Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Sat, 28 Dec 2024 21:09:50 +0000 Subject: [PATCH 1/2] fix: ensure $inspect.trace works correctly with null values --- .changeset/rotten-ligers-agree.md | 5 +++++ packages/svelte/src/internal/client/dev/tracing.js | 4 +++- .../samples/svg-namespace-if-block-3/_config.js | 11 +++++++++++ .../samples/svg-namespace-if-block-3/main.svelte | 11 +++++++++++ 4 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 .changeset/rotten-ligers-agree.md create mode 100644 packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte diff --git a/.changeset/rotten-ligers-agree.md b/.changeset/rotten-ligers-agree.md new file mode 100644 index 000000000000..53c62e7602e2 --- /dev/null +++ b/.changeset/rotten-ligers-agree.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: ensure $inspect.trace works correctly with null values diff --git a/packages/svelte/src/internal/client/dev/tracing.js b/packages/svelte/src/internal/client/dev/tracing.js index 1426e9efc9ed..302a8f648024 100644 --- a/packages/svelte/src/internal/client/dev/tracing.js +++ b/packages/svelte/src/internal/client/dev/tracing.js @@ -51,7 +51,9 @@ function log_entry(signal, entry) { status !== 'clean' ? 'color: CornflowerBlue; font-weight: bold' : 'color: grey; font-weight: bold', - typeof value === 'object' && STATE_SYMBOL in value ? snapshot(value, true) : value + typeof value === 'object' && value !== null && STATE_SYMBOL in value + ? snapshot(value, true) + : value ); if (type === '$derived') { diff --git a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js new file mode 100644 index 000000000000..66f6c2a5af5d --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js @@ -0,0 +1,11 @@ +import { test, ok } from '../../test'; + +export default test({ + html: ``, + test({ assert, target }) { + const title = target.querySelector('title'); + ok(title); + + assert.equal(title.namespaceURI, 'http://www.w3.org/2000/svg'); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte new file mode 100644 index 000000000000..f1989207a429 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte @@ -0,0 +1,11 @@ + + + + {#if title} + {title} + {/if} + + + From f0aa574814834c48a3c9f6c17e8fb15e9731d876 Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Sat, 28 Dec 2024 21:13:17 +0000 Subject: [PATCH 2/2] fix: ensure $inspect.trace works correctly with null values --- .../samples/svg-namespace-if-block-3/_config.js | 11 ----------- .../samples/svg-namespace-if-block-3/main.svelte | 11 ----------- 2 files changed, 22 deletions(-) delete mode 100644 packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js delete mode 100644 packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte diff --git a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js deleted file mode 100644 index 66f6c2a5af5d..000000000000 --- a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/_config.js +++ /dev/null @@ -1,11 +0,0 @@ -import { test, ok } from '../../test'; - -export default test({ - html: ``, - test({ assert, target }) { - const title = target.querySelector('title'); - ok(title); - - assert.equal(title.namespaceURI, 'http://www.w3.org/2000/svg'); - } -}); diff --git a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte b/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte deleted file mode 100644 index f1989207a429..000000000000 --- a/packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-3/main.svelte +++ /dev/null @@ -1,11 +0,0 @@ - - - - {#if title} - {title} - {/if} - - -