Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injected <iframe> for resize handler take up space #7481

Closed
iacore opened this issue Apr 23, 2022 · 1 comment
Closed

Injected <iframe> for resize handler take up space #7481

iacore opened this issue Apr 23, 2022 · 1 comment

Comments

@iacore
Copy link

iacore commented Apr 23, 2022

Describe the bug

Related to #4752

The inserted <iframe> has "height: 100%", which takes up more space than necessary. This will make an fixed sized element with scroll bar look weird.

The best way is not to insert any elements to for scrolllTop.

This technique is from an older version of http://www.backalleycoder.com/2013/03/18/cross-browser-event-based-element-resize-detection/, but I think it's time to fix it once and for all.

Reproduction

I'm too lazy to create a minimal example.

Run the project:

git clone https://github.com/locriacyber/idris2-quickdocs -b 0570b5aba4d553a801fe4ff7391325b4f92e90af --depth 1
yarn
yarn dev

Then type random characters very fast in the search bar, then delete them. Try this many times, and you might be lucky.

Screenshot

screenshot

Logs

N/A

System Info

N/A

Severity

annoyance

@iacore
Copy link
Author

iacore commented Apr 23, 2022

Seem to be a bug of third-party component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant