Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility error in tutorial #6265

Closed
sdserage opened this issue Apr 30, 2021 · 3 comments
Closed

Accessibility error in tutorial #6265

sdserage opened this issue Apr 30, 2021 · 3 comments

Comments

@sdserage
Copy link

sdserage commented Apr 30, 2021

Describe the bug
https://svelte.dev/tutorial/select-bindings An accessibility error occurs because on:change is being used over on:blur on the select bindings page of the Svelte tutorial.

A11y: on:blur must be used instead of on:change, unless absolutely necessary and it causes no negative consequences for keyboard only or screen reader users. (24:1)

I'm sure that this is a result to updates with accessibility, maybe worth reviewing and updating the error message or including on:blur for this section of the tutorial.

Severity
Very minor.

@sdserage
Copy link
Author

https://svelte.dev/tutorial/media-elements Another one here:

A11y: Media elements must have a <track kind="captions"> (111:0)

Example doesn't include track tag by default.

@geoffrich
Copy link
Member

geoffrich commented Apr 30, 2021

For reference: there's been previous PRs to fix the on:blur warning in the tutorial (#6189, #5861, #5037). There's an ongoing discussion in #4946 on whether this warning should be removed entirely, as it seems to only be relevant in very old IE (<11).

Similarly, the captions warning on the tutorial is tracked in #6158. There is discussion in #5967 on whether that warning should also be removed, since no browser supports <track> in <audio> elements.

@sdserage
Copy link
Author

sdserage commented May 3, 2021

Issues already exist, closing duplicate issue.

@sdserage sdserage closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants