You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Running the unit tests locally will fail when run (npm run test:unit). Specifically this test will fail.
Logs
> [email protected] test:unit /Users/fossaloaner1/GitHub/svelte
> mocha --require sucrase/register --recursive src/**/__test__.ts
get_name_from_filename
✓ uses the basename
✓ uses the directory name, if basename is index
1) handles unusual filenames
2 passing (5ms)
1 failing
1) get_name_from_filename
handles unusual filenames:
AssertionError [ERR_ASSERTION]: 'U5B_partsu5D' == 'Parts'
+ expected - actual
-U5B_partsu5D
+Parts
at Context.<anonymous> (src/compiler/compile/utils/__test__.ts:14:10)
at processImmediate (internal/timers.js:439:21)
To Reproduce
Do this:
git clone [email protected]:sveltejs/svelte.git
cd svelte/
npm install
npm run test:unit
Expected behavior
The test should pass, or be removed. We should also investigate when this broke.
Information about your Svelte project:
Cloned this project, at commit 3d9655a.
Severity
These tests don't seem to get run anywhere (aside from locally as developers), so I'd rate this as pretty low priority. I already have a fix on the way 👍
Additional context
Noticed this while I was working on #3311 and I just wanted to document this here so I have something to attach a PR to.
I was also curious why these unit tests aren't run anywhere. 🤔
The text was updated successfully, but these errors were encountered:
Describe the bug
Running the unit tests locally will fail when run (
npm run test:unit
). Specifically this test will fail.Logs
To Reproduce
Do this:
Expected behavior
The test should pass, or be removed. We should also investigate when this broke.
Information about your Svelte project:
Cloned this project, at commit 3d9655a.
Severity
These tests don't seem to get run anywhere (aside from locally as developers), so I'd rate this as pretty low priority. I already have a fix on the way 👍
Additional context
Noticed this while I was working on #3311 and I just wanted to document this here so I have something to attach a PR to.
I was also curious why these unit tests aren't run anywhere. 🤔
The text was updated successfully, but these errors were encountered: