-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't bundle the store #2786
Labels
Comments
Is there a fix for this ? Should roll up be configured to exclude store? |
Closed
diff --git a/rollup.config.js b/rollup.config.js
index 0d19e59d4..67b138732 100644
--- a/rollup.config.js
+++ b/rollup.config.js
@@ -94,12 +94,12 @@ export default [
{
file: `store.mjs`,
format: 'esm',
- paths: id => id.startsWith('svelte/') && id.replace('svelte', '.')
+ paths: () => './internal'
},
{
file: `store.js`,
format: 'cjs',
- paths: id => id.startsWith('svelte/') && id.replace('svelte', '.')
+ paths: () => './internal'
}
],
plugins: [
@@ -113,7 +113,7 @@ export default [
transforms: ['typescript']
})
],
- external: id => id.startsWith('svelte/')
+ external: () => true
},
// everything else This seems to do it but gosh is it hacky. |
For the record: another thing i tried is compilation using tsc -m es2015 -d src/store.ts --outDir . && mv store.js store.mjs
tsc -m commonjs src/store.ts --outDir . |
Merged
Fixed in #2842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#2733 switched the store to TypeScript and started bundling it, which has unintended consequences. It needs to be converted from TS, but should otherwise remain unbundled
The text was updated successfully, but these errors were encountered: