Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attr"value" generates incorrect code, instead of failing #1513

Closed
Rich-Harris opened this issue May 29, 2018 · 2 comments · Fixed by #2770
Closed

attr"value" generates incorrect code, instead of failing #1513

Rich-Harris opened this issue May 29, 2018 · 2 comments · Fixed by #2770
Labels
bug

Comments

@Rich-Harris
Copy link
Member

REPL
@EmilTholin
Copy link
Member

This throws an Error: Unexpected token now.

@Conduitry
Copy link
Member

The unexpected token error is coming from Rollup, because it's getting invalid JS from Svelte. Svelte is still generating code like attr(div, "foo"bar"", "");.

@EmilTholin EmilTholin mentioned this issue May 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error for missing equals after attribute name
3 participants
@Rich-Harris @EmilTholin @Conduitry