From fd30d854c21a26f45122b56270e12511c966ea39 Mon Sep 17 00:00:00 2001
From: mrkishi <mauriciokishi@gmail.com>
Date: Fri, 29 Nov 2019 14:06:24 -0300
Subject: [PATCH] use raf's time for smoother transitions

---
 src/runtime/internal/loop.ts | 41 +++++++++++++++++++-----------------
 test/runtime/index.js        |  2 +-
 2 files changed, 23 insertions(+), 20 deletions(-)

diff --git a/src/runtime/internal/loop.ts b/src/runtime/internal/loop.ts
index c1a42aa72422..abf00b1604c4 100644
--- a/src/runtime/internal/loop.ts
+++ b/src/runtime/internal/loop.ts
@@ -1,39 +1,42 @@
-import { now, raf } from './environment';
+import { raf } from './environment';
 
 export interface Task { abort(): void; promise: Promise<void> }
 
-const tasks = new Set();
-let running = false;
+type TaskCallback = (now: number) => boolean | void;
+type TaskEntry = { c: TaskCallback, f: () => void };
 
-function run_tasks() {
+const tasks = new Set<TaskEntry>();
+
+function run_tasks(now: number) {
 	tasks.forEach(task => {
-		if (!task[0](now())) {
+		if (!task.c(now)) {
 			tasks.delete(task);
-			task[1]();
+			task.f();
 		}
 	});
 
-	running = tasks.size > 0;
-	if (running) raf(run_tasks);
+	if (tasks.size !== 0) raf(run_tasks);
 }
 
+/**
+ * For testing purposes only!
+ */
 export function clear_loops() {
-	// for testing...
-	tasks.forEach(task => tasks.delete(task));
-	running = false;
+	tasks.clear();
 }
 
-export function loop(fn: (number) => void): Task {
-	let task;
+/**
+ * Creates a new task that runs on each raf frame
+ * until it returns a falsy value or is aborted
+ */
+export function loop(callback: TaskCallback): Task {
+	let task: TaskEntry;
 
-	if (!running) {
-		running = true;
-		raf(run_tasks);
-	}
+	if (tasks.size === 0) raf(run_tasks);
 
 	return {
-		promise: new Promise<void>(fulfil => {
-			tasks.add(task = [fn, fulfil]);
+		promise: new Promise(fulfill => {
+			tasks.add(task = { c: callback, f: fulfill });
 		}),
 		abort() {
 			tasks.delete(task);
diff --git a/test/runtime/index.js b/test/runtime/index.js
index fc989d352f1d..60bd70a5d9e2 100644
--- a/test/runtime/index.js
+++ b/test/runtime/index.js
@@ -107,7 +107,7 @@ describe("runtime", () => {
 					set_raf(cb => {
 						raf.callback = () => {
 							raf.callback = null;
-							cb();
+							cb(raf.time);
 							flush();
 						};
 					});