Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 5.7 #2649

Closed
ptrxyz opened this issue Jan 5, 2025 · 3 comments
Closed

Typescript 5.7 #2649

ptrxyz opened this issue Jan 5, 2025 · 3 comments

Comments

@ptrxyz
Copy link

ptrxyz commented Jan 5, 2025

I recently ran into some problems with svelte-check using TS5.6 while my project runs on 5.7. Basically svelte-check ends up reporting false positives, not a big issue but still annoying.

I wonder if we can make it so that svelte-check always relies on the Typescript version that is already installed in the project it runs on. Maybe declaring it as a peer dependency would do this? Is there anything we can do?

@ptrxyz
Copy link
Author

ptrxyz commented Jan 5, 2025

Oh by now VSCode also runs on TS5.7. Maybe we should upgrade anyway.

@jasonlyu123
Copy link
Member

jasonlyu123 commented Jan 5, 2025

TypeScript is already a peer dependency of svelte-check and svelte-check has always used the local typescript version. So there shouldn't be anything stopping you from upgrading. Maybe what you meant was the language server? In that case, it's using the TypeScript version bundled with the extension. Making it load the workspace version(#1045) needs a lot of work so it won't happen anytime soon but We do plan to update to TypeScrpt 5.7(#2585)

@ptrxyz
Copy link
Author

ptrxyz commented Jan 5, 2025

Thanks for the clarification, that clears things up. 👍

@ptrxyz ptrxyz closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants