You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If code existed before that was reactive to the page store and an effect was to always use goto it will trigger the reactivity in an infinite loop. Previously it was possible to use something like the following without triggering this behaviour:
If goto did not need to navigate due the search params being the same as the current page URL it would not trigger a change to the page store and would subsequently not trigger the reactivity and another call to goto. After the previously mentioned commit was added, the behaviour changed and the reactivity would always trigger a call to goto, creating an infinite navigation loop. It is now required to check if the search params of the current page are different from the ones that we want to navigate to are. If this is done an unnecessary call to goto will no longer be made and loop will never be entered.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Just wanted to share a change since this commit.
If code existed before that was reactive to the page store and an effect was to always use
goto
it will trigger the reactivity in an infinite loop. Previously it was possible to use something like the following without triggering this behaviour:If
goto
did not need to navigate due the search params being the same as the current page URL it would not trigger a change to the page store and would subsequently not trigger the reactivity and another call togoto
. After the previously mentioned commit was added, the behaviour changed and the reactivity would always trigger a call togoto
, creating an infinite navigation loop. It is now required to check if the search params of the current page are different from the ones that we want to navigate to are. If this is done an unnecessary call togoto
will no longer be made and loop will never be entered.Beta Was this translation helpful? Give feedback.
All reactions