Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: Return everything that is created during an api interface function & add a context object to all functions #215

Closed
21 of 26 tasks
rishabhpoddar opened this issue Nov 15, 2021 · 1 comment
Assignees

Comments

@rishabhpoddar
Copy link
Contributor

rishabhpoddar commented Nov 15, 2021

For example:

  • the sign up / sign in api interfaces create a new session and a new user. Both should be returned.
  • third party sign up / in also fetch the auth code response so we should return that as well (which we already do).

This is as per a new design principle that we have added.


We should also add a context object to all functions (API, recipe and sending email functions) which can be freely modifed by the user to pass info across the functions.

These should also be added to the user facing function signatures, but should be optional there.

The should also be added to functions like createAndSendCustomEmail etc..

TODO:

  • nodejs (usercontext-change branch)
    • add context to social providers
  • golang
    • userContext
    • returning session for sign up / sign in
    • testing
    • session class changes
    • Passing user context to session.revokeSession function in sign out API
    • add context to social providers
  • python
    • userContext
    • returning session for sign up / sign in
    • testing
    • session class changes
    • Passing user context to session.revokeSession function in sign out API
    • Expose regenerate session function to the user
    • add context to social providers
  • supertokens-website
  • supertokens-auth-react
  • supertokens-react-native
  • Docs
    • node
    • golang
    • python
    • website
    • auth react
@rishabhpoddar rishabhpoddar changed the title [Breaking change]: Return everything that is created during an api interface function [Breaking change]: Return everything that is created during an api interface function & add a context object to all functions Nov 15, 2021
@rishabhpoddar rishabhpoddar self-assigned this Dec 12, 2021
@rishabhpoddar
Copy link
Contributor Author

This is being done in auth-react and website in a separate issue already. So closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants