Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING CHANGE]: Separate out tpep signInUpPOST into three API interfaces that match the API spec #192

Closed
13 tasks done
rishabhpoddar opened this issue Oct 20, 2021 · 0 comments
Closed
13 tasks done

[BREAKING CHANGE]: Separate out tpep signInUpPOST into three API interfaces that match the API spec #192

rishabhpoddar opened this issue Oct 20, 2021 · 0 comments
Assignees
@bhumilsarvaiya

Comments

@rishabhpoddar
Copy link
Contributor

rishabhpoddar commented Oct 20, 2021 •
edited
Loading

TODOs:

  • NodeJS
  • GoLang
  • Docs changes
  • Demo app changes
  • Removing deprecated stuff from nodejs
  • Changing JWT to AccessToken in
    • NodeJS
    • GoLang
    • website SDK
    • auth-react SDK
    • Docs
    • React-Native
  • Change dependency of auth-react before releasing
  • API override fix in docs

Unfortunately, this needs to be a breaking change because we do not know if a user has overrided signInUpPOST or not at the time of using it. If instead, they have overrided one of the three functions it is split into, we need to use those and not signInUpPOST. Therefore, it seems that the only way out is to remove this function entirely - which makes this a breaking change.
@rishabhpoddar rishabhpoddar self-assigned this Oct 20, 2021
@rishabhpoddar rishabhpoddar changed the title Separate out tpep signInUpPOST into three API interfaces that match the API spec [BREAKING CHANGE]: Separate out tpep signInUpPOST into three API interfaces that match the API spec Oct 20, 2021
This was referenced Oct 20, 2021
Closed
Merged
Merged
Merged
Merged
@bhumilsarvaiya bhumilsarvaiya mentioned this issue Oct 22, 2021
Merged
@bhumilsarvaiya bhumilsarvaiya mentioned this issue Nov 9, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhumilsarvaiya bhumilsarvaiya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rishabhpoddar @bhumilsarvaiya