Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

[BUG] Author tag is not show correctly in RSS file #116

Closed
3 tasks done
victor-pogor opened this issue Feb 15, 2021 · 2 comments · Fixed by #117 or #184
Closed
3 tasks done

[BUG] Author tag is not show correctly in RSS file #116

victor-pogor opened this issue Feb 15, 2021 · 2 comments · Fixed by #117 or #184
Assignees
Labels
bug Something isn't working
Milestone

Comments

@victor-pogor
Copy link
Member

victor-pogor commented Feb 15, 2021

Describe the bug

As @jadmadi reported on PR #113, the <author/> tag in the RSS XML file is not showing correctly. I checked the theme via W3C RSS Validator and I found two problems:

  1. Invalid email address: Author
  2. Self reference doesn't match document location: https://example.com/index.xml

I found that email should have a specific format. The problem is that not all authors would like to reveal their email. For this purpose, there is another tag (dc:creator). The value of the dc:creator element is less restrictive than the author element, which must contain an e-mail address.

Expected behavior

  • If the email is indicated in config.toml, show the author tag.
  • If the name is indicated in config.toml, show the dc:creator tag.
  • Show correct document location

Screenshots

image

Build Environment

  • OS: Windows 10
  • Theme v0.1.0
  • Hugo version 0.78.1

Preview Environment

  • OS: Windows 10
  • Browser Chrome
@victor-pogor victor-pogor added the bug Something isn't working label Feb 15, 2021
@victor-pogor victor-pogor added this to the v0.1.2 milestone Feb 15, 2021
@victor-pogor victor-pogor self-assigned this Feb 15, 2021
victor-pogor added a commit that referenced this issue Feb 15, 2021
@victor-pogor victor-pogor linked a pull request Feb 15, 2021 that will close this issue
victor-pogor added a commit that referenced this issue Mar 8, 2021
victor-pogor added a commit that referenced this issue Mar 8, 2021
@victor-pogor victor-pogor linked a pull request Mar 8, 2021 that will close this issue
@victor-pogor
Copy link
Member Author

Hi @jadmadi. I close the #113 PR since the changes were made in another PR.

Thank you for the contribution to this repo.

@all-contributors please add @jadmadi for code and bug

@allcontributors
Copy link
Contributor

@victor-pogor

I've put up a pull request to add @jadmadi! 🎉

victor-pogor added a commit that referenced this issue Mar 14, 2021
victor-pogor added a commit that referenced this issue Mar 21, 2021
victor-pogor added a commit that referenced this issue Mar 23, 2021
victor-pogor added a commit that referenced this issue Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
1 participant