Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dnlib to AsmResolver or Mono.Cecil #50

Closed
sunnamed434 opened this issue Dec 15, 2022 · 1 comment · Fixed by #60
Closed

Migrate dnlib to AsmResolver or Mono.Cecil #50

sunnamed434 opened this issue Dec 15, 2022 · 1 comment · Fixed by #60
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@sunnamed434
Copy link
Owner

sunnamed434 commented Dec 15, 2022

AsmResolver is a great tool, I thought to move on Mono.Cecil but I believe this is a bad idea because it is easy to break with a bit of invalid metadata, AsmResolver has many perfect tools for Assembly manipulation, I do like the code and the structure, and I'm ready to learn it deeply, eg this will solve updating of MDTokens without reloading and doing machinations with assembly.

Update

Thanks to ElektroKill for his help, now there's no need to always reload the Module to update the tokens, just use ModuleDef.UpdateRowId
Btw AsmResolver has a custom thing that also allows doing the same thing!

@sunnamed434 sunnamed434 added the enhancement New feature or request label Dec 15, 2022
@sunnamed434 sunnamed434 changed the title Migrate dnlib to AsmResolver Migrate dnlib to AsmResolver or Mono.Cecil Dec 15, 2022
@sunnamed434 sunnamed434 added help wanted Extra attention is needed question Further information is requested labels Dec 16, 2022
@sunnamed434
Copy link
Owner Author

sunnamed434 commented Dec 16, 2022

pros and cons AsmResolver

+ Has more support
+ Active development
+ Last release was 1 week ago
+ Deep docs
+ Has NativeMethodBody
+ Most of those I asked to say AsmResolver is good enough
+ Has Discord with a big community
- Breaks from invalid PE (NT Signature 0x4550)

pros and cons Mono.Cecil

- Last release was a year ago
- Very simple docs
- Breaks from invalid PE (NT Signature 0x4550, CB etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant