Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You have requested a synthetic service ("request") #98

Open
vortexgin opened this issue Aug 29, 2016 · 1 comment
Open

You have requested a synthetic service ("request") #98

vortexgin opened this issue Aug 29, 2016 · 1 comment

Comments

@vortexgin
Copy link

Dear Admin,

Today i found some bug on your repository when i'm update my dependencies on symfony 2.8. Your argument on mobile_detect.twig.extension service using deprecated service, i have change your repository on my local. Here's the change :
<service id="mobile_detect.twig.extension" class="%mobile_detect.twig.extension.class%"> <argument type="service" id="mobile_detect.mobile_detector" /> <argument type="service" id="mobile_detect.device_view" /> <argument>%mobile_detect.redirect%</argument> <call method="setRequest"> <argument type="service" id="request" on-invalid="null" strict="false" /> </call> <tag name="twig.extension"/> </service>

into

<service id="mobile_detect.twig.extension" class="%mobile_detect.twig.extension.class%"> <argument type="service" id="mobile_detect.mobile_detector" /> <argument type="service" id="mobile_detect.device_view" /> <argument>%mobile_detect.redirect%</argument> <call method="setRequest"> <argument type="service" id="request_stack" on-invalid="null" strict="false" /> </call> <tag name="twig.extension"/> </service>

Please update your config or change your minimum dependencies.

@xabbuh
Copy link
Contributor

xabbuh commented Sep 3, 2016

Since this bundle depends on FrameworkBundle 2.4 or higher making use of the request stack instead of injecting the request service looks like a reasonable solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants