Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is this project dead/abandoned? #138

Open
netbull opened this issue Dec 4, 2019 · 19 comments
Open

[Question] Is this project dead/abandoned? #138

netbull opened this issue Dec 4, 2019 · 19 comments

Comments

@netbull
Copy link
Contributor

netbull commented Dec 4, 2019

First of all, thank you for the bundle! It's quite handy in many ways.

But as a cool project is quite unmaintained lately.. last PR merge is almost 2 years ago. The most vital PRs are for compatibility with Symfony 4.4 and 5 which is out now.

@DennisOluoch
Copy link

i am also concerned

@pwnyprod
Copy link

pwnyprod commented Jan 4, 2020

same here, will at least the dependencies updated for symfony5?

@DennisOluoch
Copy link

I don't think so...you will need to look out for the forks and replace this bundles with your preferred fork to get an update

@pwnyprod
Copy link

I tried start to refactor (huge pain for 2 hours), then i go over to forget this bundle and write a twig extension for my application and easily readout the server params (same like mobiledetection dependency does for mobile detection) so for me this is huge overhead and from the codebase it consume more time to refactor this. Maybe its easier to write a new Bundle.

@netbull
Copy link
Contributor Author

netbull commented Jan 17, 2020

@pwnyprod I don't know exactly what you refactored, but I forked the bundle as well and it took an hour or so and it works just fine with Symfony 4.4.x netbull/mobile-detect-bundle

@pwnyprod
Copy link

@netbull i use Symfony 5.0.x

@pwnyprod
Copy link

So lets question if @suncat2000 would give you the official branch.

@evertharmeling
Copy link

Seems like https://github.com/tattali/MobileDetectBundle is a good updated alternative, based on this repo!

@truckee
Copy link

truckee commented Jan 10, 2021

Note that https://github.com/tattali/MobileDetectBundle cannot be installed with composer require tattali/MobileDetectBundle:

[InvalidArgumentException]
Package tattali/MobileDetectBundle not found

@pwnyprod
Copy link

because its not on packagist, you have to add a vcs link in you package.json but anyway this is getting more and more outdated. A good alternative is https://github.com/Gregwar/ImageBundle

@netbull
Copy link
Contributor Author

netbull commented Jan 11, 2021

because its not on packagist, you have to add a vcs link in you package.json but anyway this is getting more and more outdated. A good alternative is https://github.com/Gregwar/ImageBundle

How image bundle is related with mobile detect?

@pwnyprod
Copy link

oh nvm :D too many projects, it was the wrong thread 🦩

@evertharmeling
Copy link

Note that https://github.com/tattali/MobileDetectBundle cannot be installed with composer require tattali/MobileDetectBundle:

[InvalidArgumentException]
Package tattali/MobileDetectBundle not found

You should install it with composer require tattali/mobile-detect-bundle (see https://packagist.org/packages/tattali/mobile-detect-bundle)

@netbull
Copy link
Contributor Author

netbull commented Jan 13, 2021

netbull/mobile-detect-bundle now can be installed via composer on Symfony 5 project

@lolop93
Copy link

lolop93 commented Aug 11, 2021

@netbull Service "mobile_detect.mobile_detector" not found: even though it exists in the app's container....

Captura de pantalla (14)

it give me this error

and this is my code
Captura de pantalla (15)

symfony 5 and php 8

@netbull
Copy link
Contributor Author

netbull commented Aug 11, 2021

@lolop93 you will need to inject the MobileDetect just like you inject the repositories.

@lolop93
Copy link

lolop93 commented Aug 11, 2021

@lolop93 you will need to inject the MobileDetect just like you inject the repositories.

@netbull i dont know how....

image

this is i have

still dont work

and this neither dont work use SunCat\MobileDetectBundle\MobileDetectBundle;

image

i do the inyection but give me this error
image

@truckee
Copy link

truckee commented Aug 11, 2021

@lolop93 FWIW, it is possible to gain the effects of the bundle using just the Twig Helper. No need to inject it. For example

{# base.html.twig #}
...
            {% if is_mobile_view() %}
                {% block nav_mobile %}
                    {% include 'Default/mobile_menu.html.twig' %}
                    {% include 'Default/top_menu.html.twig' %}
                {% endblock nav_mobile %}
            {% endif %}

@lolop93
Copy link

lolop93 commented Aug 11, 2021

@truckee @lolop93 FWIW, it is possible to gain the effects of the bundle using just the Twig Helper. No need to inject it. For example

{# base.html.twig #}
...
            {% if is_mobile_view() %}
                {% block nav_mobile %}
                    {% include 'Default/mobile_menu.html.twig' %}
                    {% include 'Default/top_menu.html.twig' %}
                {% endblock nav_mobile %}
            {% endif %}

yes i know but i prefer inject it on the controller for a better performance and readability

The twig helper works perfectly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants