diff --git a/crates/core/executor/src/dependencies.rs b/crates/core/executor/src/dependencies.rs index 0c68e5c417..ccd311cd8d 100644 --- a/crates/core/executor/src/dependencies.rs +++ b/crates/core/executor/src/dependencies.rs @@ -141,7 +141,7 @@ pub fn emit_memory_dependencies( _ => unreachable!(), }; - if most_sig_mem_value_byte >> 7 & 0x01 == 1 { + if (most_sig_mem_value_byte >> 7) & 0x01 == 1 { let sub_event = AluEvent { pc: UNUSED_PC, opcode: Opcode::SUB, diff --git a/crates/core/machine/src/air/mod.rs b/crates/core/machine/src/air/mod.rs index 0f1719c1e3..c528729f32 100644 --- a/crates/core/machine/src/air/mod.rs +++ b/crates/core/machine/src/air/mod.rs @@ -9,7 +9,6 @@ pub use word::*; use sp1_stark::air::{BaseAirBuilder, SP1AirBuilder}; /// A trait which contains methods related to memory interactions in an AIR. - pub trait SP1CoreAirBuilder: SP1AirBuilder + WordAirBuilder + MemoryAirBuilder + ProgramAirBuilder { diff --git a/crates/core/machine/src/memory/consistency/columns.rs b/crates/core/machine/src/memory/consistency/columns.rs index ef24ff7577..06a116e176 100644 --- a/crates/core/machine/src/memory/consistency/columns.rs +++ b/crates/core/machine/src/memory/consistency/columns.rs @@ -40,7 +40,7 @@ pub struct MemoryAccessCols { /// The following columns are decomposed limbs for the difference between the current access's /// timestamp and the previous access's timestamp. Note the actual value of the timestamp /// is either the accesses' shard or clk depending on the value of compare_clk. - + /// /// This column is the least significant 16 bit limb of current access timestamp - prev access /// timestamp. pub diff_16bit_limb: T, diff --git a/crates/recursion/core/src/air/memory.rs b/crates/recursion/core/src/air/memory.rs index 6803b58630..d7f76f1d73 100644 --- a/crates/recursion/core/src/air/memory.rs +++ b/crates/recursion/core/src/air/memory.rs @@ -51,7 +51,7 @@ impl MemoryInitCols { /// NOTE: These are very similar to core/src/memory/columns.rs /// The reason we cannot use those structs directly is that they use "shard". /// In our recursive VM, we don't have shards, we only have `clk` (i.e. timestamp). - +/// /// Memory read access. #[derive(AlignedBorrow, Default, Debug, Clone, Copy)] #[repr(C)] @@ -94,7 +94,7 @@ pub struct MemoryAccessCols { /// The following columns are decomposed limbs for the difference between the current access's /// timestamp and the previous access's timestamp. Note the actual value of the timestamp /// is either the accesses' shard or clk depending on the value of compare_clk. - + /// /// This column is the least significant 16 bit limb of current access timestamp - prev access /// timestamp. pub diff_16bit_limb: T, diff --git a/crates/sdk/src/network/prove.rs b/crates/sdk/src/network/prove.rs index f7f9a0b676..7251781d38 100644 --- a/crates/sdk/src/network/prove.rs +++ b/crates/sdk/src/network/prove.rs @@ -27,7 +27,7 @@ pub struct NetworkProveBuilder<'a> { pub(crate) cycle_limit: Option, } -impl<'a> NetworkProveBuilder<'a> { +impl NetworkProveBuilder<'_> { /// Set the proof kind to [`SP1ProofMode::Core`] mode. /// /// # Details diff --git a/crates/zkvm/entrypoint/src/syscalls/mod.rs b/crates/zkvm/entrypoint/src/syscalls/mod.rs index cc51f4d8ee..4fc8b6d5d9 100644 --- a/crates/zkvm/entrypoint/src/syscalls/mod.rs +++ b/crates/zkvm/entrypoint/src/syscalls/mod.rs @@ -40,7 +40,7 @@ pub use verify::*; /// These codes MUST match the codes in `core/src/runtime/syscall.rs`. There is a derived test /// that checks that the enum is consistent with the syscalls. - +/// /// Halts the program. pub const HALT: u32 = 0x00_00_00_00;