Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run pytest in pr workflow to check function test coverage #765

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat: run pytest in pr workflow to check function test coverage #765

merged 2 commits into from
Jan 7, 2025

Conversation

scgkiran
Copy link
Contributor

@scgkiran scgkiran commented Jan 7, 2025

No description provided.

@scgkiran
Copy link
Contributor Author

scgkiran commented Jan 7, 2025 •
edited
Loading

pytest Screenshot

https://github.com/substrait-io/substrait/actions/runs/12644663231/job/35232606304?pr=765

EpsilonPrime
EpsilonPrime previously approved these changes Jan 7, 2025
View reviewed changes
@EpsilonPrime EpsilonPrime merged commit 7bfc37c into substrait-io:main Jan 7, 2025
13 checks passed
@jcamachor
Copy link
Contributor

@scgkiran , any insights on why this failure might be occurring?
https://github.com/substrait-io/substrait/actions/runs/12662036941/job/35286264139?pr=766
It started happening after I rebased to include this PR and I cannot reproduce it locally. Does it have to do with some dependency version mismatch?

@scgkiran
Copy link
Contributor Author

scgkiran commented Jan 8, 2025

Does it have to do with some dependency version mismatch?

@jcamachor can you try this change?

@scgkiran scgkiran mentioned this pull request Jan 8, 2025
Merged
@scgkiran scgkiran deleted the test_coverage_in_pr branch January 8, 2025 05:10
@jcamachor
Copy link
Contributor

Does it have to do with some dependency version mismatch?

@jcamachor can you try this change?

@scgkiran , thanks, that seems to fix the issue: https://github.com/substrait-io/substrait/actions/runs/12664721192/job/35293275122?pr=766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@jacques-n jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

@cpcloud cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

@vbarua vbarua Awaiting requested review from vbarua vbarua is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scgkiran @jcamachor @EpsilonPrime