Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(naming): add missing arg names in functions_logarithmic.yaml and functions_set.yaml #319

Merged
merged 2 commits into from
Sep 8, 2022
Merged

fix(naming): add missing arg names in functions_logarithmic.yaml and functions_set.yaml #319

merged 2 commits into from
Sep 8, 2022

Conversation

vibhatha
Copy link
Contributor

@vibhatha vibhatha commented Sep 8, 2022 •
edited
Loading

This PR adds the missing argument names in functions_logarithmic.yaml and functions_set.yaml.

@vibhatha
Copy link
Contributor Author

vibhatha commented Sep 8, 2022

cc @jvanstraten is name: x is the right way or name: "x" ? I see these two patterns in the file edited in this PR.

@vibhatha vibhatha changed the title fix: Add missing arg names in logarithmic functions fix: Add missing arg names in logarithmic and set functions Sep 8, 2022
jvanstraten
jvanstraten approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jvanstraten jvanstraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no difference, both parse to a string in YAML. I don't really have a strong preference; I prefer the cleanliness of not using quotes, but then you run the risk of clashing with names that are special-cased in YAML.

@jvanstraten jvanstraten changed the title fix: Add missing arg names in logarithmic and set functions fix(naming): add missing arg names in functions_logarithmic.yaml and functions_set.yaml Sep 8, 2022
@jvanstraten jvanstraten merged commit 1c14d27 into substrait-io:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanstraten jvanstraten jvanstraten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vibhatha @jvanstraten