Syntax Tests - checking re-indentation doesn't contribute to assertion count

[keith-hall]

Description

Syntax test files which also test reindentation show the assertion count incorrectly in the syntax test build system.

Steps to reproduce

1. Create or open a syntax_test_ file with reindent in the header line - see [PHP] add indentation tests Packages#2328 for an example
2. Change the indentation of a line so it doesn't match up with the reindent command behavior
3. Build the file with the Syntax Tests build system

Expected behavior

With reindent in the header, or reindent-unchanged reindent-unindented, each line is checked 2 more times, so the assertion count shown in the output of the build system should include this.
(With just one of reindent-unchanged or reindent-unindented, each line is checked 1 more time each.)

Actual behavior

The assertion count is the same as it is without reindent in the header.

With no normal syntax test assertions, you might see:

Packages/PHP/tests/syntax_test_indentation.php:2: line was changed by a reindent
Packages/PHP/tests/syntax_test_indentation.php:2: line did not reach same indentation from an unindented state
FAILED: 2 of 0 assertions in 1 files failed
[Finished]

2 out of 0 doesn't seem correct... If there are i.e. 10 lines, there are 20 assertions, so it should be out of 20.

Environment

• Build: 4073
• Operating system and version: Ubuntu 19.10
• [Linux] Desktop Environment and/or Window Manager: XFCE4, X11

[BenjaminSchaaf]

We've got a fix for this in the pipeline

[BenjaminSchaaf]

Should be fixed in 4072