[#976] Handles zero as max for rand #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve `Faker::Base.rand` to handle zero (0) as max value and restore documented behaviour for some methods that depend on it Closes #976
landongrindheim
pushed a commit
to landongrindheim/faker
that referenced
this pull request
Oct 7, 2017
Improve `Faker::Base.rand` to handle zero (0) as max value and restore documented behaviour for some methods that depend on it Closes faker-ruby#976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
Faker::Base.randto handle zero (0) as max value and restoredocumented behaviour for some methods that depend on it
Closes #976
Notes:
Could not restore
Kernel.randbehavior since now there're a couple of Fakers depending onRandom::DEFAULTbehavior (Bitcoin being one). I had to handle this internally on theFaker::Base.rand.Any suggestion is welcome