LoremFlickr support #818
Merged
LoremFlickr support #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests. Updated docs.
…ing all search_terms.
b264
reviewed
Mar 20, 2017
lib/faker/lorem_flickr.rb
Outdated
| build_url(size, 'p', search_terms, match_all) | ||
| end | ||
|
|
||
| def colorized_image(size = '300x300', color = 'red', search_terms = [], match_all = false) |
There was a problem hiding this comment.
I think search_terms needs a valid default value
There was a problem hiding this comment.
Yeah, I'll put something like search_terms = ['all'] 👍
|
I've refactored the |
|
Will do @vbrazo 👍 |
Pull Request Test Coverage Report for Build 2147
💛 - Coveralls |
|
You should run |
|
@vbrazo should be all sorted now 🙌 |
vbrazo
approved these changes
May 17, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Added doc] to get started. * Added the LoremFlickr faker class. * Added lorem_flickr to the list of requires. * Added tests for the LoremFlickr class. * Changed search_term to search_terms which takes an array of strings. Updated tests. Updated docs. * Added the match_all parameter so it returns the url of an image matching all search_terms. * Added LoremFlickr to README. * Extracted building out URL to separate method. * Added LoremFlickr.pixelated_image. * Added LoremFlickr.colorized_image. * Added tests for supported colorizations. * Added tests to check that an error is thrown when given an unsupported size. * Added valid default values for methods requiring search_terms. * Updated the docs. * Added documentation for more parameter combinations. * Added separate method for creating grayscale images. * Updated the docs with the new grayscale_image method. * Removed the is_gray parameter from the image method. * Updated the docs. * Fixed Rubocop offenses. * Added title of PR and Github ID to CHANGELOG.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
Faker::LoremPixel, but you get a wider range of images using LoremFlickr.You not only get grayscale images. You also get pixelated and colorized images.