Modify Faker::Educator, Fix #576 #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should make |
|
Thank you for your feedback @b264. It makes sense to make an alias for |
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def to
a5d7731
Compare
vbrazo
requested changes
Jul 1, 2018
There was a problem hiding this comment.
@ghbooth12 could you please update your branch with master and fix the rubocop violations?
|
@vbrazo Absolutely. I'm sorry for my late reply. I'll update this PR this afternoon. |
ghbooth12
force-pushed
the
576-sector-for-universities-and-companies
branch
from
f2fcf57 to
9e67622
Compare
vbrazo
approved these changes
Aug 20, 2018
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add subject, course_name, degree method for Faker::Educator (Fix faker-ruby#576) * Update educator.rb * Update educator.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. This PR is about fixing the issue #576 by adding a method 'subject'. Additionally I have edited the
Faker::Educator.coursemethod. Because the existingcoursemethod returns a string like "Associate Degree in Criminology". I think this is a name of degree, not a name of course. So I have renamed thecoursemethod to thedegreemethod. Then I have created the newcoursemethod that returns something like "Criminology 201".subjectmethod that returns something like "Criminology", "Engineering", "Business"...coursemethod todegreemethodcoursemethod that returns something like "Criminology 201", "Engineering 411", "Business 157"...The tests for these changes have been added and all have passed. The documentation(faker/doc/educator.md) has updated for these changes.