Add gender to name generator

[MaicolBen]

This fixes #289

Not merge yet! First a question:

@stympy Does I have to distinguish the gender in all language files? Or put in them a alias to first_name instead?

[stympy]

You don't need to modify all the locale files... as long as the old first_name method works across all locales, I'm happy. :)

[MaicolBen]

I had to check if parse doesn't return empty in the cases that first name is defined as single string (the locales that don't have gender), that's fine?

[MindRave]

@MaicolBen, @stympy hello! Is this coming anytime soon ? :) Thanks in advance!

[MaicolBen]

Rebased, I made sure that the name's locals weren't updated

[MindRave]

@MaicolBen thank you for the speed! 👍 This looks great! I hope @stympy can merge this into the main repo soon. :)

[b264]

If it doesn't merge, there is male_name and female_name in https://github.com/factory-helper/factory-helper

[MindRave]

@b264 thank you. Will check it out, at least until the PR is merged into faker itself. That, or I'll end up separating the male/female names into arrays and doing a ".sample" on them. 😅 In any case, thanks a lot!

[vbrazo]

Thanks for contributing 🥇 Nice work!

Could you rebase this branch and run Rubocop to make sure that we're following a few good practices?

[vbrazo]

@MaicolBen could you also update the CHANGELOG.md and add the title of this PR + your GitHub ID?

[MaicolBen]

@vbrazo Done! You should add rubocop to travis or add Code Climate

[vbrazo]

@MaicolBen You should write tests for male_first_name and female_first_name . I know that they're pretty simple, but we need to have them in place and green to make sure that things are ok.

[vbrazo]

Any updates on this PR?

[MaicolBen]

@vbrazo Sorry, I was on vacation. Also, I rebased tons of time this PR since I created it (look at the creation date). While rebasing I saw the middle name was added copying from first names from both genders (lib/locales/en/name.yml), that's a bad approach, I would take a random one from first_name

[vbrazo]

@MaicolBen we worked on the middle name locales and I remember that we copied this information from the web. Feel free to open a new PR and propose the change.